Re: [bug-inetutils] Many complaints on HAVE_..._SHORT_NAME

[Mats Erik Andersson]

torsdag den 16 juni 2011 klockan 18:03 skrev Alfred M. Szmidt detta:
> Can you try this and see if it works?  You need to make sure that
> config.h is regenerated to not include any local hacks.  If it works,
> I'll commit it since any changes to autoconf, if they will be done,
> will take a while to propagate into a release.
> 
> 2011-06-17  Alfred M. Szmidt  <address@hidden>
> 
>       * libinetutils/libinetutils.h: Don't include <config.h>; instead
>       produce an error if we haven't included it.
> 
> diff --git a/libinetutils/libinetutils.h b/libinetutils/libinetutils.h
> index 8cfe792..56174e1 100644
> --- a/libinetutils/libinetutils.h
> +++ b/libinetutils/libinetutils.h
> @@ -17,7 +17,9 @@
>    You should have received a copy of the GNU General Public License
>    along with this program.  If not, see `http://www.gnu.org/licenses/'. */
>  
> -#include <config.h>
> +#ifndef HAVE_CONFIG_H
> +#error "<config.h> has not been included; please included it"
> +#endif
>  
>  #include "argp-version-etc.h"

With an up-to-date tree I had to issue

   $ git reset --hard e0ecda

since the recent sighandler patch is broken in OpenBSD.

Then I applied your patch. The compilation completes in OpenBSD 4.6
without any problems, and without the warnings that initiated this
thread. Let me add that the warnings have appeared in the last few
months, because there has been some time since I built the complete
source on any of my systems. I am positive that those warnings were
not present earlier on.

By chance I did notice that the configuration step issued on NexentaCore
produces the empty file 'config.hin]'. Observe the bracket. There Bash
is the preferred shell. I even issued 'make distclean', and the file
was generated again. Could there be a defect in the bootstrap code?
The bootstrap was issued on a system running Debian GNU/Linux testing.

Regards,
  Mats