[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] [Platform-testers] inetutils pre-release
From: |
Mats Erik Andersson |
Subject: |
Re: [bug-inetutils] [Platform-testers] inetutils pre-release |
Date: |
Thu, 17 Nov 2011 23:20:33 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
måndag den 14 november 2011 klockan 11:21 skrev Simon Josefsson detta:
> Bruno Haible <address@hidden> writes:
> > In other words, you need to add $(LIBREADLINE) to the value of LDADD
> > in telnet/Makefile.am.
> >
> > Likewise in telnetd/Makefile.am.
>
> Thanks for analyzing, I agree and pushed this tiny change in your name.
>
> > Quite odd situation, but IMO the readline macro should not set
> > HAVE_LIBREADLINE
> > if the include files are missing, or the code in ftp/cmds.c should be
> > testing
> > HAVE_LIBREADLINE && HAVE_READLINE_READLINE_H
> > instead of just
> > HAVE_LIBREADLINE
>
> Yes. However, wouldn't an even better solution be to use
> AC_LIB_LINKFLAGS here instead of the current check for readline? That
> should be more reliable.
Related to this is the fact that <term.h> must be prepended by <curses.h>
in all standards. Also <stropts.h> is needed with HAVE_STREAMSPTY.
The commit 0a83fb1 attends to these matters and it achieves correct
building of telnet and telnetd for
GNU/Linux, GNU/kFreeBSD, GNU/OpenSolaris, OpenBSD, and OpenIndiana.
Best regards,
Mats
- [bug-inetutils] inetutils pre-release, Simon Josefsson, 2011/11/13
- Re: [bug-inetutils] [Platform-testers] inetutils pre-release, Bruno Haible, 2011/11/13
- Re: [bug-inetutils] [Platform-testers] inetutils pre-release, Simon Josefsson, 2011/11/14
- Re: [bug-inetutils] [Platform-testers] inetutils pre-release,
Mats Erik Andersson <=
- Re: [bug-inetutils] [Platform-testers] inetutils pre-release, Mats Erik Andersson, 2011/11/17
- Re: [bug-inetutils] [Platform-testers] inetutils pre-release, Simon Josefsson, 2011/11/18
- [bug-inetutils] Readline code (Was: [Platform-testers] ...), Mats Erik Andersson, 2011/11/18
- Re: [bug-inetutils] Readline code, Simon Josefsson, 2011/11/19
- Re: [bug-inetutils] Readline code, Simon Josefsson, 2011/11/19
- Re: [bug-inetutils] Readline code, Mats Erik Andersson, 2011/11/19
- Re: [bug-inetutils] Readline code, Simon Josefsson, 2011/11/19
- Re: [bug-inetutils] Readline code, Mats Erik Andersson, 2011/11/19
- Re: [bug-inetutils] Readline code, Simon Josefsson, 2011/11/19
- Re: [bug-inetutils] Readline code, Alfred M. Szmidt, 2011/11/19