bug-libunistring
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-libunistring] Fix quoting in exported.sh.in, allow multiple arg


From: Ralf Wildenhues
Subject: Re: [bug-libunistring] Fix quoting in exported.sh.in, allow multiple arguments.
Date: Sat, 2 May 2009 10:00:25 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Ralf Wildenhues wrote on Fri, May 01, 2009 at 07:31:52PM CEST:
> * Bruno Haible wrote on Fri, May 01, 2009 at 01:53:04PM CEST:
> > > Quote argument to eval, to avoid losing TABs from @GLOBAL_SYMBOL_PIPE@
> > 
> > Hmm. I used exactly the same kind of quoting as libtool. Namely, the
> > configure file contains the following code, expanded from libtool.m4:
> 
> >     if { (eval echo "$as_me:$LINENO: \"$NM conftest.$ac_objext \| 
> > $lt_cv_sys_global_symbol_pipe \> $nlist\"") >&5
> >   (eval $NM conftest.$ac_objext \| $lt_cv_sys_global_symbol_pipe \> $nlist) 
> > 2>&5
> 
> Thanks!  Guess that should be fixed then, too.  Of course it also pretty
> much proves that no nm implementation really uses leading TABs in their
> output.

I've pushed this to Libtool.  While this still causes wrongly quoted
output in config.log, at least the actual command tested is right.
A better fix will require a better AC_TRY_EVAL replacement from
Autoconf.

Cheers, and thanks again,
Ralf

    Fix quoting of eval'ed variable.
    
    * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS): Double-quote
    $lt_cv_sys_global_symbol_pipe for eval, like we do in ltmain,
    in order to preserve TABs and multiple adjacent whitespace.
    Report by Bruno Haible.

diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 63e831e..8e4bca9 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -3380,7 +3380,7 @@ _LT_EOF
   if AC_TRY_EVAL(ac_compile); then
     # Now try to grab the symbols.
     nlist=conftest.nm
-    if AC_TRY_EVAL(NM conftest.$ac_objext \| $lt_cv_sys_global_symbol_pipe \> 
$nlist) && test -s "$nlist"; then
+    if AC_TRY_EVAL(NM conftest.$ac_objext \| "$lt_cv_sys_global_symbol_pipe" 
\> $nlist) && test -s "$nlist"; then
       # Try sorting and uniquifying the output.
       if sort "$nlist" | uniq > "$nlist"T; then
        mv -f "$nlist"T "$nlist"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]