[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hyphens not working in 2.13
From: |
Chris Snyder |
Subject: |
Re: hyphens not working in 2.13 |
Date: |
Mon, 29 Jun 2009 21:15:31 -0400 |
User-agent: |
Thunderbird 2.0.0.22 (X11/20090608) |
> The regression test and the underlying logic of the fix attempt are
> wrong IMHO , because they do not test the existence of additional
> lyrics. If the "no more lyrics" case is problematic, this shouldn't
> break the case in that there are actually additional lyrics. Anyway,
> now the extender is prematurely stopped with or without slurred notes
> or additional lyrics, as the last Karim's example shows.
Sorry for the regression. It's possible that there actually are
regression tests that show it, but the delta-calculating logic in the
tests doesn't deal well with the thin extender lines (which I noted when
I submitted the patch).
It will be difficult for me to write a patch to fix this right now, as
I'm limited to a crappy hotel Internet connection for the next couple of
days, but I'll look into a fix if no-one beats me to it. I think the
proper solution would be to add a check for the single-underscore case,
and avoid completizing the extender if one is found.
Chris Snyder
Adoro Music Publishing
http://www.adoromusicpub.com