Re: PATCH: Lyrics break estimation of vertical spacing

[Reinhold Kainhofer]

Am Montag, 12. April 2010 22:43:30 schrieb Boris Shingarov:
> Hi Neil,
> 
> > If you use the same test branch as your original patch (which is
> > 
>   > associated with a particular issue on Rietveld), you can just apply
>   > the revised patch and upload again (git-cl will ask you for a
>   > description which becomes the title of the new patch set on Rietveld.)
> 
> I am not sure I am following, esp. the git-cl part.  The state of the
> test branch right now is simply a clone of the HEAD.  I had made some
> changes, then ran the "upload.py" script to generate the first patch. 

Ah, you might want to install git-cl, which is a git interface to the 
upload.py script. It stores the issue for you current branch, and when you do 
a second upload on the same branch, it will reuse that issue number...

> This was without any commits.  Then, I made some corrections, and
> re-ran "upload.py" again -- this is the revised patch.  Sure I can do
> a diff of the two patches, but how do I get that diff to Rietveld?

You don't have to do that yourself. Just upload the new patch to the same 
issue on Rietveld, and the server will create the diff of the patches for 
you...

Cheers,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org