bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1061 in lilypond: Pure-height inaccuracy very large when skyl


From: lilypond
Subject: Re: Issue 1061 in lilypond: Pure-height inaccuracy very large when skyline significantly non-rectangular
Date: Thu, 22 Apr 2010 19:59:58 +0000


Comment #1 on issue 1061 by joeneeman: Pure-height inaccuracy very large when skyline significantly non-rectangular
http://code.google.com/p/lilypond/issues/detail?id=1061

I only get the attached output when the patch for Issue 1053 is applied. I think this points to a problem in System::part_of_line_pure_height, which is only including the staves and not the various other objects which live in System (like bar numbers).

The fix, I think, would be to factor out axis-group-interface.cc:231-265 into a
separate function and to modify it so that it uses begin_of_line_extent or
end_of_line_extent whenever it encounters a VerticalAxisGroup. Then replace calls to
System::part_of_line_pure_height with calls to this new function.

Regarding lyric descenders, this is not really a problem with pure height estimation; rather, it is a problem in approximating systems with bounding boxes during page breaking (that is, the estimates for the bounding boxes are actually ok but the
bounding boxes are poor approximations to the skylines).

By the way, the space at the bottom will be much less ugly if you turn off ragged-bottom.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings




reply via email to

[Prev in Thread] Current Thread [Next in Thread]