[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Part_combine_iterator::last_playing_ not initialized
From: |
Dmytro O. Redchuk |
Subject: |
Re: Part_combine_iterator::last_playing_ not initialized |
Date: |
Mon, 22 Aug 2011 15:06:14 +0300 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sun 21 Aug 2011, 02:44 Dan Eble wrote:
> % valgrind reports that a member of Part_combine_iterator is used
> % before being initialized. Initializing last_playing_ = SOLO1 in
> % the constructor makes the warning go away.
> \version "2.14.2"
>
> \partcombine { s } { s }
Added this as 1829:
http://code.google.com/p/lilypond/issues/detail?id=1829
Thank you!
On Mon 22 Aug 2011, 00:14 Graham Percival wrote:
> IMO, please push any patch that initializes variables as long as
> they don't break a regtest. In the worst case, you would just
> introduce a reproducible bug, instead of having us "rely" on
> having an uninitialized variable.
>
> (if you notice broken regtests as a result of your patch, then
> let's discuss it before pushing)
Ha-ha, I've decided that type-defect and _security_ are the best for this
issue. I am in doubt. _Performance_? -- not sure. Anything else? What?-)
--
Dmytro O. Redchuk "Easy to use" is easy to say.
Bug Squad -- Jeff Garbers
Re: Part_combine_iterator::last_playing_ not initialized,
Dmytro O. Redchuk <=