[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 1128 in lilypond: Text pedal mark not closed at music end
From: |
lilypond |
Subject: |
Re: Issue 1128 in lilypond: Text pedal mark not closed at music end |
Date: |
Wed, 14 Sep 2011 18:27:18 +0000 |
Comment #3 on issue 1128 by address@hidden: Text pedal mark not
closed at music end
http://code.google.com/p/lilypond/issues/detail?id=1128
The problem is that the brackets use a spanner, which will properly end,
while the text style uses separate grobs for each of the texts
("Ped.", "*Ped." and "*"). Now, if a \sustainOn does not have a closing
\sustainOff, we can handle that case in the Engraver's finalize () method.
Unfortunately, it seems that at that time it is too late to create a new
grob for the final "*", but we don't know before whether we need a
final "*"....
I've tried to implement the creation of the "*" in ::finalize, but the
following patch always crashes (valgrind shows access to some unallocated
memory in the page breaking code):
http://codereview.appspot.com/5015045
So, apparently creating a grob for "*" in ::finalize does not work. Any
idea how to make this work?
- Re: Issue 1128 in lilypond: Text pedal mark not closed at music end,
lilypond <=