bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grace note articulation


From: James
Subject: Re: grace note articulation
Date: Mon, 24 Dec 2012 15:13:00 +0000

Zefram,

On 23 December 2012 13:20, Zefram <address@hidden> wrote:
> The attached patch makes \articulate handle grace notes, which fixes a
> load of "going back in MIDI time" errors.
>
> Mike Solomon said I should send my patches here, for a regular developer
> to put them on Rietveld.
>

It depends on how quick you want them looked at.

It is as much work for you to upload your own patches to Rietveld

https://codereview.appspot.com

as it is for anyone else really.

I suggest that you, yourself create three Rietveld issues and post the
links to the dev mail list at least they will get reviewed.

If you create the issues yourself then you will also get notified when
someone comments and corrects, else someone has to be a go between for
a patch-in progress and upload each diff for you. It is a lot of admin
work for someone else to be honest (I know, I have done it in the
past), I don't think people will mind doing one patch to start with
but you have 3 now so I think if you do intend to help the LP project
more long term that you at least get familiar with git-cl

http://lilypond.org/doc/v2.17/Documentation/contributor-big-page#uploading-a-patch-for-review

The patches not ony has to be put up on Rietveld but it has to be
tracked too, this also helps with the automated patch testing (to make
sure it doens't break anything current).

Throwing them to a mail list will, I fear, not get you anywhere (even
with Mike's good intentions).

I don't want to discourage you, there are people who will help, but at
some point you might as well take a few minutes to learn the work flow
and the testing and reviews will just happen.

James



reply via email to

[Prev in Thread] Current Thread [Next in Thread]