[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: old-straight-flag + smaller Stem.thickness gives no output and huge
From: |
Mike Solomon |
Subject: |
Re: old-straight-flag + smaller Stem.thickness gives no output and huge overflow |
Date: |
Mon, 27 May 2013 20:01:09 +0200 |
On 27 mai 2013, at 19:34, David Kastrup <address@hidden> wrote:
> David Kastrup <address@hidden> writes:
>
>> Karol Majewski <address@hidden> writes:
>>
>>> The following code gives:
>>> warning: cannot fit music on page: overflow is 1096.382978
>>> and no output. Perhaps it's a bug?
>>>
>>> \version "2.17.19"
>>>
>>> \layout {
>>> \context {
>>> \Score
>>> \override Stem.thickness = #1.2
>>> \override Flag.stencil = #old-straight-flag
>>> }
>>> }
>>>
>>> {
>>> c'16 r r d' c' r r d' c' r r d' c' r r d'
>>> c' r r d' c' r r d' c' r r d' c' r r d'
>>> c' r r d' c' r r d' c' r r d' c' r r d'
>>> }
>>>
>>> When I set Stem.thickness to default (1.3) everything is OK.
>>>
>>> Version 2.16.2 gives valid output regardless of Stem.thickness value.
>>
>> Looks like a really scary bug. 2.17.12 seems to have this still work.
>> This would have seemed like a really strong argument against the spacing
>> changes I just committed. Except that this problem was introduced
>> several versions before them. Bisecting now.
>
> 6f13ef4a292625c1a9d528ac88aec98071ba6388 is the first bad commit
> commit 6f13ef4a292625c1a9d528ac88aec98071ba6388
> Author: Mike Solomon <address@hidden>
> Date: Fri Mar 22 07:29:57 2013 +0100
>
> Permits all positive and zero-length buildings in skylines (issue 3161)
>
> This allows point stencils to figure into vertical spacing, as shown
> in the new regtest input/regression/skyline-point-extent.ly.
>
> Some issues regarding floating point errors were raised while reviewing
> this patch, but it was concluded that the math in this patch likely does
> not risk triggering those errors with the way GCC compiles the code.
>
> :040000 040000 aba0cd7599a6552a82de6e9a33994fea9b0b7d25
> 3bf49df5489da0394cd3c51467a9bb8a7370281a M input
> :040000 040000 c79887feb521e70a01928a004b7d0afd1d41738f
> 095d598721861e8fe5e9f49107dfa06456636cc1 M lily
> :040000 040000 5981ae9efc78292a365259d883ba2a99ec1a1e77
> f2f6bae625b7e31d2f695676de1010a756e8552a M scm
>
>
> --
> David Kastrup
>
Ahhhhh crap. I'll look into it this week.
Cheers,
MS
Re: old-straight-flag + smaller Stem.thickness gives no output and huge overflow, Marek Klein, 2013/05/29