[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Case-insensitive targets
From: |
Gisle Vanem |
Subject: |
Re: Case-insensitive targets |
Date: |
Thu, 2 Aug 2018 20:56:13 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Paul Smith wrote:
Then there's the question of case-preserving or not. To be case-
preserving, make would have to be doing all string searches and
comparisons using case-insensitive implementations which would be a lot
of code churn. And we would have to care a lot more about
internationalization since case comparison is highly locale-specific.
Thanks for the detailed explanation.
Besides, there seems to be a mem-leak in that loop.
I see no mem leak in that function...?
Ops, you're right. But there are tons of them elsewhere.
Won't hurt and maybe intentional. I removed the mentioned
'assert()' and see no aborts anywhere else.
But I made a little <dmalloc.h> implementation using MSVC's
<CrtDbg.h> and dumped the leaks right before 'exit()' in
main.c's 'die()'. The simple case-insensitive-win.mak in my
1st email shows 4410 leaks!
PS. the makefile and diff used for this _DEBUG-mode test is at:
https://gist.github.com/gvanem/e8d2db10aa6899c752e5df032fd66785
--
--gv
- Case-insensitive targets, Gisle Vanem, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/02
- Re: Case-insensitive targets, Gisle Vanem, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/02
- Re: Case-insensitive targets, Paul Smith, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/02
- Re: Case-insensitive targets,
Gisle Vanem <=
- Re: Case-insensitive targets, Paul Smith, 2018/08/02
- Re: Case-insensitive targets, David Boyce, 2018/08/02
- Re: Case-insensitive targets, Eli Zaretskii, 2018/08/03