Re: ncurses: Makefile dependencies?

[Thomas Dickey]

On Sat, Oct 21, 2006 at 10:14:46AM +0200, Ralf S. Engelschall wrote:
> In the OpenPKG "ncurses" package some time ago we had to add a bunch
> of additional dependencies to the Makefiles in order to allow NCurses
> to build without trouble on all of our supported Unix platforms. As
> we are carrying this patch for a longer time, I no longer know which
> particular platforms caused the problems and whether the additional
> dependencies are _still really needed_. So, just don't take this over
> as is but please review it in detail and use this as a hint for your
> own checking of the internal NCurses dependencies. Well, OTOH these
> additional dependencies wouldn't _hurt_ even if a newer investigation
> shows that they are no longer really needed...

But - while the dependencies are useful for development (changing the source
in a library unit will help relink the programs), they shouldn't be needed
for building.
 
> Index: ncurses/Makefile.in
> --- ncurses/Makefile.in.orig  Wed Dec 22 13:02:27 2004
> +++ ncurses/Makefile.in       Wed Dec 22 13:02:30 2004
> @@ -273,7 +273,8 @@
>       @ECHO_LINK@ $(CC) -o $@ $(CFLAGS_DEFAULT) -DHASHDEBUG 
> $(serial)/hashmap.c $(TEST_LDFLAGS)
> 
>  lib_mvcur$x : $(serial)/lib_mvcur.c $(TEST_DEPS) \
> -             ../@DFT_OBJ_SUBDIR@/dump_entry$o
> +             ../@DFT_OBJ_SUBDIR@/dump_entry$o \
> +             ../@DFT_OBJ_SUBDIR@/comp_parse$o
>       @ECHO_LINK@ $(CC) -o $@ $(CFLAGS_DEFAULT) -DNCURSES_TEST 
> -I$(serial)/../../progs $(serial)/lib_mvcur.c 
> ../@DFT_OBJ_SUBDIR@/dump_entry$o $(TEST_LDFLAGS)

for instance, this one is adding a dependency for one particular object
file (comp_parse.o) where the object file is already part of the library
file defined in $(TEST_DEPS).
 
>  link_test$x : link_test.c $(TEST_DEPS) \
> Index: progs/Makefile.in
> --- progs/Makefile.in.orig    Sat Nov  1 23:45:57 2003
> +++ progs/Makefile.in Wed Dec 22 13:04:07 2004
> @@ -192,7 +192,8 @@
> 
>  DEPS_TIC = \
>       $(MODEL)/tic$o \
> -     $(MODEL)/dump_entry$o
> +     $(MODEL)/dump_entry$o \
> +     $(MODEL)/comp_parse$o

In this case, the library file is from a different directory (and there
is no corresponding source in progs for comp_parse.c).
 
-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature