bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ncurses-5.9-20111022.patch.gz


From: Damien Guibouret
Subject: Re: ncurses-5.9-20111022.patch.gz
Date: Sun, 23 Oct 2011 17:20:02 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050416

Thomas Dickey wrote:
On Sun, 23 Oct 2011, Damien Guibouret wrote:

Hello,

I take a look at this last patch and I have a strange feeling on _mouse_mask2 use: in get_mouse and _nc_mouse_parse functions, everywhere you used _mouse_mask2 I would had kept _mouse_mask and everywhere you kept


I made a copy, because _mouse_mask is returned to the caller in the mousemask() function - the last parmeter. The caller should only get back what it provided in a previous call.

(I noticed the problem a week ago while testing dialog - essentially just run the password script in its samples directory, and click on the text-field while doing tabs to switch the button focus - some of the clicks were lost).

I agree with the need of the copy, that's a good thing. What I do not agree on, is where it is used: in my opinion for get_mouse and _nc_mouse_parse functions (and only those functions) the copy should be used where the original is used and vice-versa.

Regards,

Damien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]