Re: PRep-boot partition flag support.

[Sven Luther]

On Mon, Nov 29, 2004 at 09:28:07AM +1100, Andrew Clausen wrote:
> On Sat, Nov 27, 2004 at 10:27:55AM +0100, Sven Luther wrote:
> > Other patches in the debian package which may be of interest are : 
> > 
> > amiga.dpatch:
> >   Adds amiga filesystem support
> 
> It adds both filesystem probe and full partition table support, right?
> The patch looks good... I'm just wondering if you should print
> out a warning about it being unstable?  (How much in-the-wild use has it
> seen?)
> 
> Perhaps put this in amiga_read():
> 
>       ped_exception_throw (
>               PED_EXCEPTION_WARNING,
>               PED_EXCEPTION_OK_CANCEL,
>               _("The software to support for Amiga partition tables "
>                 "is new and has not been widely tested."))
> 
> > no-clobber.dpatch:
> >   Removed a fs->clobber assertion that did break since the
> >   amiga filesystem does not provide a clobber op.
> 
> Remind me why the amiga file system doesn't have a clobber op?
> 
> > s390.dpatch:
> >   Another s390 bigger sector size patch, replaces Bastian's
> >   more limited sector-size pactch.
> 
> Are we looking at the same thing?  The s390.dpatch in the debian/testing
> package is support for s390 partition tables.  We would need a copyright
> disclaimer or assignment for this one...
> 
> I just got a USB key image sent to me that has non-512-byte sector
> size.  I'll have to have a look at this...
> 
> > sun_disklabel.dpatch:
> >   Some older sun disk labels were previously misparsed.
> 
> Looks fine.

BTW, for the smaller patches like this one, it would make more sense if you
did commit them ? Does this sound good to you ? 

Friendly,

Sven Luther