Re: Errors while probing devices in GNU/Hurd.

[hde]

Quoting Andrew Clausen <address@hidden>:

> On Sun, Dec 19, 2004 at 11:46:06PM -0600, Harley D. Eades III wrote:
> > I did some cosmetic changes as well. :)
> > 
> > What does everyone think?
> 
> I don't know enough about the Hurd to comment.  (What is the difference
> between store_open() and store_typed_open()?)
store_open opens a store (i.e /dev/hd0, /dev/hda(Linux)) but the passing arg
must be a path.  store_type_open opens a store also but the arg passed must be a
store-typed name (i.e device:hd0 == /dev/hd0) store-type:name.  Store typed
names allow the Hurd to use basically anything as a store (file, gzip file,
device etc).
 
> I don't like the GNU coding style, so I'm not a big fan of the cosmetic
> changes.  (GNU Parted mostly follows the Linux coding style.) In
> particular, I much prefer 8-space indentation.  But, I don't care
> very much - especially for code that relates to Hurd ;)
I can change to the patch not to do the cosmetic changes if you perfer.

> Feel free to commit to CVS...
Will do thanks.
 
Thanks
Harley