bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FW: Publish the changes


From: leslie . polzer
Subject: Re: FW: Publish the changes
Date: Wed, 27 Jul 2005 00:20:37 +0200
User-agent: mutt-ng devel (Linux)

On Tue, Jul 26, 2005 at 02:00:18PM -0700, Jen, Janet (Windows IPF Engineer) 
wrote:
>    We are making the changes and will send the file when it is done.
>    Are there any other changes that need to be made?
Please create all patches against current CVS. The changes in disk.c,
for example, have an offset of about 70 lines, which is too much fuzz for
the patch utility -- we'd have to fix that by hand.
So please update the patch against current CVS instead of Parted 1.6.22. 

> @@ -514,8 +521,14 @@
>                                            (uint16_t) pte->PartitionName[i]);
>         gpt_part_data->name[i] = 0;
> 
> -       gpt_part_data->lvm = gpt_part_data->raid = gpt_part_data->boot
> -               = gpt_part_data->hp_service = 0;
> +       gpt_part_data->lvm = gpt_part_data->raid = 
> +               gpt_part_data->boot = gpt_part_data->hp_service = 
> +                       gpt_part_data->hidden = gpt_part_data->msftres = 0;
> +
Move the equals relation to the beginning of the succeeding line and stay
at one tab indent.


I had a quick look at the rest and did not find any problems, but I'll take
a second and closer look later.


> If the code looks fine, what is the next step for us?
When the patch is accepted it will be committed to CVS.
You can get it from the repository then or wait for Parted 1.6.24.

Regards,

Leslie

-- 
PGP-KID: 0x52D70289

Attachment: pgp0qtQkdlWHi.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]