Re: [PATCH] Move formatting out of translatable strings.

[Otavio Salvador]

Benno Schulenberg <address@hidden> writes:

> Otavio Salvador wrote:
>> Benno Schulenberg <address@hidden> writes:
>> > Benno Schulenberg wrote:
>> >> Here's a somewhat better version of that patch, removing the
>> >> superflouus parentheses and some whitespace.
>> >
>> > Any chance for this patch of getting applied, Otavio?
>>
>> Please, resend it. I probably missed it.
>
> Both of them attached.
>
> The VTOC_ERROR and FDASD_ERROR defines have to go, because the word 
> "error" would be untranslatable that way.  Besides, it is customary 
> to preceed an error message with just the name of the component.
>
> Be aware, though, that I've not signed any copyright assignment 
> papers, just in case Parted requires this.

I'd suggest you to redo the patches using a clear message on the
commit. It looks difficult to know where you've change those things.

Maybe:

 vtoc label: Move formatting out of translatable strings.
 fdasd label: Move formatting out of translatable strings.

Otherwise both will look as the same change and don't give any
information where they have changed things.

There's any problem to you to do the assigment?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: address@hidden      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."