Re: parted-1.9.0 -- comments and patches

[Joel Granados]

On Mon, Aug 03, 2009 at 11:53:11AM +0200, Peter Breitenlohner wrote:
> On Mon, 3 Aug 2009, Joel Granados wrote:
>
>> This should be primary not pirmary.
>> Can you pls try again.
>

Peter:

Thx for your feedback. It is much appreciated.  My comments bellow.

> Hi Joel,
>
> did it again as root, in the parted build directory, and got:
>       echo n | ./parted ---pretend-input-tty testfile \
>       "mklabel gpt mkpart primary ext3 1 -1"
> Warning: The existing disk label on 
> /.th/thsrc/archive/gnu/parted/parted-1.9.0-build-linux-gnu/parted/testfile 
> will be destroyed and all data on this disk will be lost. Do you want to 
> continue?
> /home/pcl321/peb/archive/gnu/parted/parted-1.9.0-build-linux-gnu/parted/.libs/lt-parted:
>  invalid token: mkpart
> Yes/No? n

you must regenerate the testfile once more.  `dd if=.....`

>
> Note: /home/pcl321/peb/archive -> /.th/thsrc/archive
>
> The above was with parted-1.9.0;

Untill now, there is no interest in maintaining a bug fix branch for
1.9.0.  Especially for something that happens in a test, so I must
insist you stop testing with 1.9.0.  The next branch is very different
from what we released and testing on 1.9.0 is just a wast of time IMO.
Additionally, the next branch contains lots of bugfixes already, so you
might be hitting something that is already solved in next.

> for parted-git I still get:

I assume parted-git means the next branch in the git repo.

>       echo n | ./parted ---pretend-input-tty testfile \
>       "mklabel gpt mkpart primary ext3 1 -1"
> Error: Can't have the end before the start!

I have the same results as you.  I think this is due to the fact that
when there is not size type, it defaults to Mb.  So, this behavior is
expected.

>
> However, for parted-git and doing as in the test case:
>       echo n | ./parted ---pretend-input-tty testfile \
>       "mklabel gpt mkpart primary ext3 1s -1s"

hrm, I had not noticed that I had missed the "s", good catch.

> Warning: The existing disk label on 
> /.th/thsrc/archive/gnu/parted/parted-git/parted/testfile will be destroyed 
> and all data on this disk will be lost. Do you want to continue?
> /home/pcl321/peb/archive/gnu/parted/parted-git/parted/.libs/lt-parted: 
> invalid token: mkpart
> Yes/No? n

My results:

1.
if I do a `./configure --without-readline` and then install I get the
result you are seeing [*], but my `make check` still does not fail.  I
assume thtat the normalize scripts take care or this.  The normilize
scripts are the sed lines.

2.
if I do a `./configure` and then install I get the same output except
for the "n" at the end of the yes/no question.  And my `make check` does
not fail.

3.
if I do a `./configure --without-device-mapper` its the same as 3.

What distro are you using?  Maybe I can reproduce if I can get closer to
what your environment looks like.

[*] : the "n" at the end of the yes/no question.

Regards.

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

pgpRPu6H476vf.pgp
Description: PGP signature