Re: [bug-patch] [PATCH 00/15] *** SUBJECT HERE ***

[Jim Meyering]

Andreas Gruenbacher wrote:

> Jim,
>
> On Saturday 26 March 2011 14:31:55 Jim Meyering wrote:
>> In the interest of getting patch into a form
>> that will integrate more easily with diffutils,
>> here are some changes that make most of gnulib's
>> syntax-check rules pass (the others are skipped for now).
>>
>> The changes cover a mixture of style, portability, safety,
>> and increasing consistency with other GNU packages.
>
> thanks, I like this.  I only have one nit-picking comment.
>
>> Jim Meyering (15):
>>   maint: use gnulib's maintainer-makefile module
>>   maint: arrange for the sc_require_config_h_first test to pass
>>   maint: add some m4 quoting
>>   maint: remove trailing blanks
>>   maint: allow the sc_prohibit_empty_lines_at_EOF test to pass
>>   maint: avoid non-portable use of test -a
>>   build: accept new configure-time option --enable-gcc-warnings
>>   tests: temporarily disable failing syntax-check rules
>
> You have sc_prohibit_always-defined_macros in local-checks-to-skip twice here.
>
>>   build: avoid three gcc warnings
>>   maint: update copyright date year ranges to include 2011
>>   maint: update bootstrap and gnulib submodule
>>   maint: use gnulib's progname module
>>   maint: remove now-unneeded macro definitions
>>   build: don't turn off -Wmissing-prototypes
>>   build: don't turn off -Wmissing-declarations

Thanks for the review.
I've fixed that and pushed the result, along with this change:

>From aa85679b9affab4f15b45a8f719d6e002f06f8c3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 26 Mar 2011 17:04:39 +0100
Subject: [PATCH] maint: ignore more build artifacts

---
 .gitignore    |    9 ++++++---
 m4/.gitignore |    1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 120c9e7..97631f3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,18 +4,22 @@
 /.pc/
 /.version
 /ChangeLog
+/GNUmakefile
+/ID
 /INSTALL
 /VERSION
 /aclocal.m4
 /autom4te.cache/
 /build-aux
+/config.cache
 /config.h
 /config.hin
-/config.hin~
 /config.log
 /config.status
 /configure
+/doc
 /lib
+/maint.mk
 /patch-*.tar.bz2
 /patch-*.tar.bz2.sig
 /patch-*.tar.gz
@@ -26,5 +30,4 @@
 /stamp-h1
 Makefile
 Makefile.in
-build-aux
-doc
+TAGS
diff --git a/m4/.gitignore b/m4/.gitignore
index aab56be..29db97d 100644
--- a/m4/.gitignore
+++ b/m4/.gitignore
@@ -68,6 +68,7 @@
 /safe-read.m4
 /safe-write.m4
 /setenv.m4
+/signal_h.m4
 /size_max.m4
 /ssize_t.m4
 /stat-time.m4
--
1.7.4.1.688.g95e3e