[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-pyconfigure] uninstall target can miss some files
From: |
Afif Elghraoui |
Subject: |
Re: [Bug-pyconfigure] uninstall target can miss some files |
Date: |
Tue, 19 Jan 2016 20:43:26 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Hello,
على الثلاثاء 19 كانون الثاني 2016 14:06، كتب Brandon Invergo:
>
> Sorry it took so long to get to this.
No problem. I was just testing out pyconfigure and didn't really need it
for a project.
> In any case, I believe this
> problem has been fixed among the latest commits that I pushed. I intend
> to make a release sometime later this week. I need to poke around the
> code a bit to see if there are any other problems that I missed. If you
> noticed anything else, now would be a good time.
>
> On Tue, 2015-12-22 at 20:45 -0800, Afif Elghraoui wrote:
>> In Makefile.in, if you have something like:
>>
>> SCRIPTS = bin/*
>>
>> make uninstall will not remove the scripts because it executes something
>> like:
>>
>> rm -rvf <prefix>/bin/bin/*
>
> DON'T DO THIS! If you want to do a wildcard in a Makefile, use the
> wildcard function:
>
[...]
Fair enough. That was a bad example, because the point I was trying to
make was that if one of the strings in SCRIPTS has a directory as part
of it, the make uninstall target won't work properly. The key was to
have $(notdir $(SCRIPTS)), which it looks like you've taken care of.
>
> Regardless, this made me see that I was a bit too cavalier with my rm
> statements, so they're toned down a bit and should be a tiny bit
> safer, but nothing I could do could protect from something like bin/*.
>
That was a careless example on my part. Thanks for taking care of this,
though.
regards
Afif
--
Afif Elghraoui | عفيف الغراوي
http://afif.ghraoui.name
signature.asc
Description: OpenPGP digital signature