bug-rcs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Branch not showing up in rlog (git build 40f6256)


From: Hannes Küttner
Subject: Re: Branch not showing up in rlog (git build 40f6256)
Date: Tue, 6 Dec 2016 16:12:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Hi again!

After going through the commit history I figured out, that the offending commit is 68687516.


Fix stack crash for long branches

This does not fix all recursive calls, just enough to fix
likely cases, including the bug report by Haoming Chu at:
http://lists.gnu.org/archive/html/bug-rcs/2016-10/msg00002.html
* rlog.c (putadelta): Do not check ‘node->selector’; now the
caller’s responsibility.  Remove arg TRUNK; now inferred from
other args.  All callers changed.
(putadelta, putrunk): Omit ‘register’ as the compiler should
figure this stuff out nowadays.
* rcsgen.c (putree):
* rlog.c (putree, exttree, recentdate, extdate):
Avoid recursion in the common case where !root->branches.
* rlog.c (putree): Avoid recursion when outputting the last tree
in the forest.
(putabranch): Do not check whether arg is null; now the
caller’s responsibility.  Avoid recursion in the common case
where !root->selector.
(putforest): Return last tree in the forest.
(extractdelta): Return bool, not char.
(extdate): Return size_t, not int.  All callers changed.


I'm going to dig deeper now.

Mit freundlichem Gruß / With kind regards
Hannes Küttner

 MEINBERG Funkuhren GmbH & Co. KG
Lange Wand 9
D-31812 Bad Pyrmont, Germany
Phone: +49 (0)5281 9309-0
Fax: +49 (0)5281 9309-30
Amtsgericht Hannover 17HRA 100322
Geschäftsführer: Günter Meinberg, Werner Meinberg, Andre Hartmann, Heiko Gerstung
Email: address@hidden

Internet: www.meinberg.de


MEINBERG - Solutions for Time and Frequency Synchronization

reply via email to

[Prev in Thread] Current Thread [Next in Thread]