Re: [Bug-readline] Fix building readline on future OS X versions, and also cleanup the relevant code

[Chet Ramey]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/27/14 1:17 PM, Max Horn wrote:

>> Sure, let me see your approach.
> 
> OK, here is what I am doing in my OS X readline6 package for Fink (a dpkg 
> based package manager): Instead of using
> 
>    -install_name $(libdir)/$@
> 
> in shobj-conf, I use
> 
>   -install_name $(libdir)/`echo $@ | sed "s:\\(.*\\.[0-9]\\)\\.[0-9]:\\1:"`
> 
> This parallels the logic in support/shlib-install, around line 109, which 
> creates symlinks
>    libFOO.x.dylib  -> libFOO.x.y.dylib
>    libFOO.dylib    -> libFOO.x.y.dylib
> 
> If you see a more elegant way, please let me know.

Not necessarily more elegant, but less complicated.  You can use the fact
that the target ($@) is of the form `libreadline.stuff', and you don't care
about `stuff'.  You can use $(SHLIB_MAJOR), which is already computed for
you, and not worry about the major version number.  That reduces the
command to

- -install_name $(libdir)/`echo $@ | sed
"s:\\..*::"`.$(SHLIB_MAJOR).$(SHLIB_LIBSUFF)

> By the way:  support/config.guess is really old (from 2009, it seems). 
> Amongst other things, it does not distinguish between 32bit and 64bit OS X 
> environments. Right now, that doesn't seem to be a problem, but perhaps it 
> would be a good idea to update it (and perhaps also support/config.sub, which 
> was last updated in 2008, it seems)

Thanks, I've already updated these.

Chet
- -- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLmxZMACgkQu1hp8GTqdKszpQCfel2+vgIfRap9vUGZq9PaS0J1
jXEAnRbbrgi0Mr60qZVYdDZOo5MamhK5
=lj9e
-----END PGP SIGNATURE-----