Re: [Bug-sysutils] argp and getline() patch for remove-shell

[David Weinehall]

On Fri, Jun 04, 2004 at 08:14:55PM +0200, Marco Gerards wrote:
> Barry deFreese <address@hidden> writes:
> 
> > OK, here is the patch for remove-shell.
> 
> [...]
> 
> > Index: src/remove-shell.c
> > ===================================================================
> > RCS file: /cvsroot/sysutils/sysutils/src/remove-shell.c,v
> > retrieving revision 1.2
> > diff -r1.2 remove-shell.c
> > 21a22,23
> >> #define _GNU_SOURCE
> >> #include <argp.h>
> 
> Normally you don't define _GNU_SOURCE in the sourcecode.  I think it
> should be set by autoconf.

Righto.  However, I'm not all that confident that my autoconf-code is
particularly correct yet.  Feel free to have a look at it.  In fact,
most includes in the source-files are incorrect (well, at least the
assumptions that the included files indeed exist and/or provide the
expected functionality), so I'd be really delighted if you, or someone
else, would have a look at them.


Regards: David Weinehall
-- 
 /) David Weinehall <address@hidden> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/