Re: [Bug-sysutils] getline patch for gshadow

[David Weinehall]

On Fri, Jun 04, 2004 at 08:46:14PM +0200, Marco Gerards wrote:
> Barry deFreese <address@hidden> writes:
> 
> > OK, I changed gshadow.c to use getline rather than fgets.  Let me know
> > what you think.
> 
> Great, I love getline.  I think you need an autoconf test and add some
> stuff from gnulib as well, right?  _GNU_SOURCE shouldn't be set here,
> I think.

Only problem is that I realised, after assigning this job to Barry,
that this makes fgetsgent behave in a different manner than
fgetpwent, fgetgrent, and fgetspent; all these have a static buffer,
but getline allocates memory.  NOT nice.  So I've decided, that at least
for the time being, I'm going to ignore that patch.  Sad, but true.

PS: Sorry again for the invenience, Barry.


Regards: David Weinehall
-- 
 /) David Weinehall <address@hidden> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/