[Bug-tar] gnu tar: patch/featureadd => --block-dev-contents

[Andrew Somerville]

> -----Original Message-----
> From: Paul Eggert [mailto:address@hidden]
> Sent: Wednesday, July 30, 2003 3:37 PM
> To: Andrew Somerville
> Cc: 'address@hidden'
> Subject: Re: [Bug-tar] gnu tar: patch/featureadd
>
> Assuming that problem can be resolved, the proposed patch is
> incomplete.  Please submit it in "diff -pu" format,

Done.

> with a proposed
> ChangeLog entry for it; see
> <http://mail.gnu.org/archive/html/bug-gnulib/2003-07/msg00124.html>
> for an example. 

Done.

> Please use the GNU coding standards for code that you
> write in the patch.  Please check every system call to see whether it
> fails, and report an error if a failure occurs.  You can look at the
> current code for how this is done.

Done. (I think it is to standard ? System call checked)

>
> Also, let's not use a short option like -D for this.  A long
> option is good enough.  We're running out of short options.

changed to --block-dev-contents
>
> Finally, why should block special devices be treated any differently
> from character special devices?  Shouldn't the option be called
> something like --device-contents instead, and affect both block and
> character special devices?

addressed in previous email.

Finally, I wanted to make an entry for the man page, but I have no idea about how to go about that. Please advise.

        Regards,
        Andrew Somerville

 

changelog.entry
Description: Binary data

tar.c.diff.1.13.25
Description: Binary data

create.c.diff.1.13.25
Description: Binary data

common.h.diff.1.13.25
Description: Binary data