[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-tar] Re: one more warning in argp-help
From: |
Jim Meyering |
Subject: |
[Bug-tar] Re: one more warning in argp-help |
Date: |
Sat, 10 Dec 2005 23:19:11 +0100 |
Eric Blake <address@hidden> wrote:
> I noticed on cygwin that I was getting a warning for buf being declared at
> line argp-help.c:1895 but not used. This patch also fixes a lot of
> trailing whitespace; let me know if you don't want whitespace patches.
It's not my call here, but I'll give you my opinion anyhow :-)
IMHO, this is pretty important.
Removing trailing blanks is a worthy goal, but it is better never to
mix white-space-only changes and any other type of change. The white-
space-only hunks make it hard to find the significant part of the patch.