Re: [Bug-tar] [PATCH] tar: remove unused macros

[Sergey Poznyakoff]

Paul Eggert <address@hidden> ha escrit:

> I pushed this minor cleanup patch.  I'm not sure what that
> DIR_IS_NEW macro was for, but it looks like it may be a bug
> that it's not being used, so I marked it with a FIXME and
> commented it out rather than removing it entirely.

I have no objections as to DIR_IS_NEW, but removing these:

> * src/tar.c (LOW_DENSITY_NUM, MID_DENSITY_NUM, HIGH_DENSITY_NUM):

is an error.  These macros are used in tar.c:2119-2127, and this
change breaks compilation when DEVICE_PREFIX is defined while
configuring.

It is deduced from the value of the DEFAULT_ARCHIVE configuration
variable, and provides support for the traditional options `-[0-7][lmh]'
options, e.g., -1m.  I don't know how many people still rely on this,
but I suppose there are some.  Please, restore these.

Regards,
Sergey