[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] [patch v3] Bug / question in tar
From: |
Pavel Raiskup |
Subject: |
Re: [Bug-tar] [patch v3] Bug / question in tar |
Date: |
Fri, 14 Mar 2014 16:09:32 +0100 |
User-agent: |
KMail/4.12.3 (Linux/3.13.6-200.fc20.x86_64; KDE/4.12.3; x86_64; ; ) |
On Friday, March 14, 2014 14:13:35 Sergey Poznyakoff wrote:
> Hi all,
>
> > I'd like to see Sergey's opinion.
>
> I think we should apply the patch. However, I doubt if the use of
> "script" in the testsuite is OK. I'm going to write a simple auxiliary
> program that would use ptys to emulate tty devices; that way we'll be
> able to run the test on the platforms that lack script.
Such simple binary would be useful but making it perfectly portable may
cost some time. I tried to use e.g. the busybox implementation of script
and it is broken (at least on my system) for as simple usage as we have.
So I don't know whether we should not put some lightweight test in place
in the meantime. Possibly we could avoid 'script' usage as long as stdin
is tty 'test -t 0 || fallback_script || AT_SKIP_TEST'? Originally was
'script' important because I mistakenly wanted to add the isatty(stdout)
check - and it is not truth anymore. But still, for `make check 0>&-` we
should not fail.
Pavel
- Re: [Bug-tar] [patch v3] Bug / question in tar, (continued)
- Re: [Bug-tar] [patch v3] Bug / question in tar, Pavel Raiskup, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Paul Eggert, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Markus Steinborn, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Eric Blake, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Pavel Raiskup, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Paul Eggert, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Pavel Raiskup, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Paul Eggert, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Pavel Raiskup, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Sergey Poznyakoff, 2014/03/14
- Re: [Bug-tar] [patch v3] Bug / question in tar,
Pavel Raiskup <=
- Re: [Bug-tar] [patch v3] Bug / question in tar, Markus Steinborn, 2014/03/13
- Re: [Bug-tar] [patch v3] Bug / question in tar, Sergey Poznyakoff, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Pavel Raiskup, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Sergey Poznyakoff, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Sergey Poznyakoff, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Antonio Diaz Diaz, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Eric Blake, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Karl Berry, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Paul Eggert, 2014/03/20
- Re: [Bug-tar] [patch v3] Bug / question in tar, Karl Berry, 2014/03/20