|
From: | Pavel Raiskup |
Subject: | Re: [Bug-tar] infinite symlink directory loop causes segfault with --create --dereference |
Date: | Tue, 15 Jul 2014 23:15:42 +0200 |
User-agent: | KMail/4.12.5 (Linux/3.15.4-200.fc20.x86_64; KDE/4.12.5; x86_64; ; ) |
On Wednesday 09 of July 2014 10:59:49 Paul Eggert wrote: > Pavel Raiskup wrote: > > Are we talking about removing recursion completely? > > That'd be one way, I suppose. Or perhaps we can just trap segfaults and > exit more nicely with a diagnostic. Lets try the first approach. Attached patch (0001-*) was tested on directory hierarchy with depth about ~30k. The main problem then becomes the memory consumption because we need to keep complete stat info of each part of currently dumped path in memory. We could free it out and re-stat again but that would be another patch.. Attaching also the previous patch (0002-*) adapted to patched HEAD (as the two problems are orthogonal). Out of curiosity, Paul, could you point me to some (preferably GNU) project trapping segfaults in a portable way? Pavel
0001-tar-avoid-recursion-in-directory-traversal.patch
Description: Text Data
0002-create-do-not-segfault-with-dereference.patch
Description: Text Data
testsuite.log.xz
Description: application/xz
root-testsuite.log.xz
Description: application/xz
[Prev in Thread] | Current Thread | [Next in Thread] |