Re: [Bug-tar] [PATCH 2/2] tar: set stdin/stdout to binary mode on OS/2 if not console

[KO Myung-Hun]

Pavel Raiskup wrote:
> On Monday 24 of November 2014 12:25:45 KO Myung-Hun wrote:
>> Hi/2.
>>
>> KO Myung-Hun wrote:
>>>
>>>
>>> Paul Eggert wrote:
>>>> Myung-Hun KO wrote:
>>>>> But any special reasons why binary-io module of gnulib should
>>>>> be used instead of pre-existent SET_BINARY_MODE() ? In addition,
>>>>> SET_BINARY_MODE() is being used already.
>>>>
>>>> My impression is that the proposed patch is reimplementing binary-io,
>>>> which would mean it's better to bite the bullet and just use it.
>>>>
>>>>
>>>
>>> I've updated the patches.
>>
>> Updated, again.
> 
> Hi Myung-Hun KO,
> 
> [ad 0002]
> 
> neither you nor Paul have spoken about pros/cons of particular
> implementation.
> 
> From me, I also think that using binary-io makes sense.  Your patches are
> clearly portability fixes and this is what is gnulib for (pros: you'll get
> another portability fixes from any gnulib user in future).  What about
> switch paxutils/tar source to use binary-io?
> 

Frankly, I don't know what I can get when using binary-io of gnulib
instead of paxutils. Difference is that SET_BINARY is used instead of
SET_BINARY_MODE, when using binary-io.

Anyway, whether using paxutils or using binary-io is not a problem. What
is important is getting working codes and applying OS/2 patches.

I attach a updated patch using binary-io, and will send patches for
paxutils separately.

Review, please...

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

0001-tar-set-stdin-stdout-to-binary-mode-correctly-with-b.patch
Description: Text document