bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] [PATCH] xheader: avoid pointer-arith warning


From: Paul Eggert
Subject: Re: [Bug-tar] [PATCH] xheader: avoid pointer-arith warning
Date: Thu, 18 Dec 2014 02:02:36 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

Sergey Poznyakoff wrote:
-  cp = obstack_next_free (xhdr->stk) - xhdr->string_length - p - 1;
+  cp = (char*) obstack_next_free (xhdr->stk) - xhdr->string_length - p - 1;

The usual GNU style is to have a space before the "*". Better yet, avoid the cast entirely:

   cp = obstack_next_free (xhdr->stk);
   cp -= xhdr->string_length + p + 1;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]