[Bug-tar] [PATCH (tests)] --files-from and recursive extract (behavior change in 1.27)

[Pavel Raiskup]

On Friday 19 of June 2015 15:53:52 Pavel Raiskup wrote:
> On Friday 19 of June 2015 15:20:04 Jan Engelhardt wrote:
> > On Friday 2015-06-19 14:29, Pavel Raiskup wrote:
> > >> 
> > >> >> The patch fix the first issue I reported, but not the second.
> > >> 
> > >> This patch, which was recently backported to openSUSE's tar-1.28[1]
> > >> 
> > >> [1] 
> > >> https://build.opensuse.org/package/view_file/Base:System/tar/tar-recursive--files-from.patch?expand=1
> > >> 
> > >> breaks creation of tar archives when --no-recursive appears after -T:
> > >>   https://bugzilla.opensuse.org/show_bug.cgi?id=918487
> > >
> > >I'm not sure whether this was discussed off-list somehow, but I would call
> > >the *new* behavior as expected.  There is inconsistency in behavior - yes,
> > >but does not seem to be regression, rather a new feature..?
> > 
> > It feels very much like a regression, because the behavior changed
> > in such a way that it changed the outcome of scripts making use of
> > that option.
> >
> > By default, people will assume that options are position-independent,
> > that specifying no-argument options multiple times is idempotent
> > unless otherwise specified, and that specifying with-argument options
> > have a last-win strategy unless otherwise specified.
> >
> > TTBOMK, only --verbose is spelled out to change behavior if present
> > multiple times, but there is no word on multiple-presence of
> > position-dependence of --(no-)recursion in tar.info.
> 
> Hmm, actually, I looked at the documentation and it's been documented
> since 2003 [1], however I failed to find any working tar release (tried
> v1.16.1 and up).  Fix came with thread [3].
> 
> [1] http://git.savannah.gnu.org/cgit/tar.git/commit/?id=01d81c7f0fc87
> [2] http://www.gnu.org/software/tar/manual/html_section/tar_54.html#recurse
> [3] https://lists.gnu.org/archive/html/bug-tar/2014-01/msg00020.html

I'm attaching patch with new tests for '-T' and '--recursion'.  Could we
install that?

There is still one expected failure:  If --recursion is set from within -T
file argument, it is processed too late.  To fix that we would need to
implement something like NELT_RECURSION probably to make --recursion fully
flexible.

Pavel

0001-tests-better-test-no-recursion-options.patch
Description: Text Data