[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-time] FW: POSIX output should not start with "Command exited wi
|
From: |
Petr Pisar |
|
Subject: |
Re: [Bug-time] FW: POSIX output should not start with "Command exited with non-zero status" line |
|
Date: |
Thu, 9 Nov 2017 12:30:01 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Nov 09, 2017 at 12:03:23PM +0100, Petr Pisar wrote:
> Great. The only issue is the newly added test fails randomly with:
>
> FAIL: tests/time-posix-quiet
> ============================
>
> --- out-default 2017-11-09 11:50:52.642813091 +0100
> +++ exp-default 2017-11-09 11:50:52.635813098 +0100
> @@ -1,3 +1,3 @@
> Command exited with non-zero status
> -user system :elapsed %CPU (avgtext+avgdata maxresident)k
> +user system :elapsed ?%CPU (avgtext+avgdata maxresident)k
> inputs+outputs (major+minor)pagefaults swaps
> --- out-q 2017-11-09 11:50:52.652813081 +0100
> +++ exp-q 2017-11-09 11:50:52.646813087 +0100
> @@ -1,2 +1,2 @@
> -user system :elapsed %CPU (avgtext+avgdata maxresident)k
> +user system :elapsed ?%CPU (avgtext+avgdata maxresident)k
> inputs+outputs (major+minor)pagefaults swaps
> FAIL tests/time-posix-quiet.sh (exit status: 1)
>
> Maybe it's because time reports randomly 0%CPU and 100%CPU:
>
A added some debuging code and actually vanilla time reports three different
values:
0%CPU
100%CPU
?%CPU
It passes with the last one, fails with the two previous. But the probability
distribution significantly varries whether I run the test suite or "./time
false".
Attached patch fixes the test.
-- Petr
time-1.8-Accept-numeric-values-in-tests-time-posix-quiet.sh.patch
Description: Text document
signature.asc
Description: PGP signature