bug-vc-dwim
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-vc-dwim] time for a new release


From: Jim Meyering
Subject: Re: [Bug-vc-dwim] time for a new release
Date: Thu, 22 Dec 2011 22:13:43 +0100

Ralf Wildenhues wrote:
> * Jim Meyering wrote on Sun, Dec 18, 2011 at 04:50:26PM CET:
>> I'm ready to make a new release.
>> Ralf, do you have any pending changes for vc-chlog?
>
> Nope, fire away.

Hi Ralf,

Pre-release testing showed a new failure on my rawhide system,
where "finger" happened not to be installed.  That showed that
vc-chlog was always invoking finger, and hence failing on that
system.  Here's the patch I expect to push soon:

>From 44d93b056a3b2c481dbf1299e30642d9ddb59cdb Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 22 Dec 2011 22:11:15 +0100
Subject: [PATCH] vc-chlog: run finger only as a last resort, as intended

* vc-chlog.in (user_name): Fix an omission that made nearly every
invocation of vc-chlog run "finger $USER" unnecessarily.
---
 vc-chlog.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/vc-chlog.in b/vc-chlog.in
index b1527e1..43b192a 100755
--- a/vc-chlog.in
+++ b/vc-chlog.in
@@ -78,6 +78,7 @@ PATCH="@PATCH@"

 today=`date +%Y-%m-%d`
 test -z "$USER" && USER=`id -nu`
+user_name=$USER
 test -z "$user_name" &&
   user_name=`finger $USER | sed -n '
       /.*Name: /{
--
1.7.8.1.285.g92f25



reply via email to

[Prev in Thread] Current Thread [Next in Thread]