[VCDImager Bugs/Devel] Some issues concerning compilation of vcdimager under Solaris

[Dagobert Michelsen]

Hi,

two modifications were needed to compile vcdimager-0.6.0 under
Solaris, where one of them seems to be a more general bug.
The fixes were run against the 0.5.9beta4 sources, but the
bugs are still in the 0.6.0 version.
I am not very familiar with autoconf, so the fixes provided
need to be reworked to be useful in a general way.

1. Missing include produces the following error under Solaris:

gcc -DHAVE_CONFIG_H -I. -I. -I../..  -I ../../libvcd/     -g -O2 -Wall -Wunused 
 -Wall -Wmissing-prototypes -Wunused -Wpointer-arith -Wwrite-strings -c 
vcdimager.c
vcdimager.c: In function `_add_dir':
vcdimager.c:182: storage size of `st' isn't known
vcdimager.c:196: warning: implicit declaration of function `stat'
vcdimager.c:199: warning: implicit declaration of function `S_ISDIR'
vcdimager.c:204: warning: implicit declaration of function `S_ISREG'
vcdimager.c:182: warning: unused variable `st'

This can be easily fixed with the following patch:

diff -Naur vcdimager-0.5.9beta4/frontends/cli/vcdimager.c 
vcdimager-0.5.9beta4-new/frontends/cli/vcdimager.c
--- vcdimager-0.5.9beta4/frontends/cli/vcdimager.c      Sun Mar 18 01:13:01 2001
+++ vcdimager-0.5.9beta4-new/frontends/cli/vcdimager.c  Fri Apr  6 22:58:42 2001
@@ -32,6 +32,7 @@
 #include <string.h>
 #include <sys/mman.h>
 #include <sys/types.h>
+#include <sys/stat.h>
 #include <unistd.h>
 
 #include "vcd_types.h"

A separate check in the configure script seems adequate to me.

2. A field in the definition for non-bigendian-architectures
   was renamed in one location. Fixing is easy:

diff -Naur vcdimager-0.5.9beta4/libvcd/vcd_files_private.h 
vcdimager-0.5.9beta4-new/libvcd/vcd_files_private.h
--- vcdimager-0.5.9beta4/libvcd/vcd_files_private.h     Fri Mar  9 02:02:38 2001
+++ vcdimager-0.5.9beta4-new/libvcd/vcd_files_private.h Fri Apr  6 22:59:15 2001
@@ -107,7 +107,7 @@
 #else
   uint8_t reserved2 : 1;
   uint8_t use_track3 : 1;
-  uint8_t use_lid1 : 1;
+  uint8_t use_lid2 : 1;
   uint8_t user_data_cc : 1;
   uint8_t special_info : 1;
   uint8_t restriction : 2;



Thanks for the great software :-)

  -- Dagobert Michelsen

-- 
Dagobert Michelsen            Leiter IT, Baltic Online Computer GmbH
Fon: +49 (0) 431-54003-0 Fax: -99        http://www.baltic-online.de
Big servers, SAN?      address@hidden, jetzt auch in Hamburg!
Remember where you wanted to go yesterday?      Click. Click. Crash.