[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-wget] Re: download rate display bug --
From: |
Paul Townsend |
Subject: |
[Bug-wget] Re: download rate display bug -- |
Date: |
Wed, 27 Jan 2010 01:03:23 -0500 |
Ummm. I should have also said that I am working on a "--terse" option
that limits its output to a single line describing the local file that
looks (a lot) like the "--verbose" summary line. The "progress"
variable isn't set, however, so the rate computations are dependent on
the "elapsed" variable being set.
-- PT
On Wed, 27 Jan 2010 00:25:56 EST, Paul Townsend wrote:
>=====
>I'm pretty sure this is a (typo?) bug. I couldn't find it in the "all
>open bugs" list at "http://wget.addictivecode.org/BugTracker". Unless I
>did something really stupid when configuring (a possibility :-)), the
>code that computes the download rate for http downloads is incorrect.
>Without the patch below, I saw download rates of up to multi-hundreds
>of terabytes and a total download rate of petabytes. It would be really
>nice if I could actually get that kind of speed (;-})
>
>--- wget-1.12/src/retr.c.orig 2009-09-04 12:31:54.000000000 -0400
>+++ wget-1.12/src/retr.c 2010-01-26 00:38:38.317706000 -0500
>@@ -301,7 +301,7 @@
> else if (ret <= 0)
> break; /* EOF or read error */
>
>- if (progress || opt.limit_rate)
>+ if (progress || opt.limit_rate || elapsed)
> {
> ptimer_measure (timer);
> if (ret > 0)
>
>Note that "elapsed" is included in the conditional above that allows
>`ptimer_new()' to be called.
>
>-- Paul Townsend