Re: [Bug-wget] wget fails to encode spaces in URLs

[Giuseppe Scrivano]

Hi Volker,

I see it now, thanks.  This small patch makes sure the url is parsed in
any case.

Cheers,
Giuseppe



=== modified file 'src/retr.c'
--- src/retr.c  2011-06-05 12:31:24 +0000
+++ src/retr.c  2011-06-08 09:29:20 +0000
@@ -1005,9 +1005,7 @@
           break;
         }
 
-      /* Need to reparse the url, since it didn't have iri information. */
-      if (opt.enable_iri)
-          parsed_url = url_parse (cur_url->url->url, NULL, tmpiri, true);
+      parsed_url = url_parse (cur_url->url->url, NULL, tmpiri, true);
 
       if ((opt.recursive || opt.page_requisites)
           && (cur_url->url->scheme != SCHEME_FTP || getproxy (cur_url->url)))



Volker Kuhlmann <address@hidden> writes:

> Hi Giuseppe,
>
> Thanks!
>
> I compiled it with libproxy: same problem.
>
> I then compiled it with just 
>   ./configure --prefix=/tmp/.../
>   make
>
> ./src/wget -i-
> http://downloads.sourceforge.net/project/bandwidthd/bandwidthd/bandwidthd 
> 2.0.1/bandwidthd-2.0.1.tgz?r=&ts=1307308092&use_mirror=transact
> ^D
>
> (note the space after bandwidthd) and wireshark gives me:
>
> GET /project/bandwidthd/bandwidthd/bandwidthd 
> 2.0.1/bandwidthd-2.0.1.tgz?r=&ts=1307308092&use_mirror=transact HTTP/1.1
> User-Agent: Wget/1.12-2504 (linux-gnu)
> Accept: */*
> Host: downloads.sourceforge.net
> Connection: Keep-Alive
>
>
> Sorry NOT FIXED.
>
>
> My system and user wgetrc contain
>
> prefer-family = none
>
> use_proxy = off
> dirstruct = on
> timestamping = on
> dot_bytes = 64k
> dot_spacing = 10
> dots_in_line = 50
> backup_converted = on
>
>
> Volker