[Bug-wget] Some potential memory leaks in wget-1.3

[Zhenbo Xu]

Hi, wget,
I have applied a memory leak detection tool
Melton<http://lcs.ios.ac.cn/~xuzb/melton.html> to
find memory leaks in wget-1.3.
Some potential bugs were found, and I check them manually as the real bugs.
Here is the index url of thes bugs:
http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/wget-1.13/realbugs/index.html

Or you can download it from the following url:
http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/wget-1.13/realbugs_wget_1.13.tar.gz

Hope for your replies.

Some explanations are given below:

*Bug No. 7 and No. 8:*
a heap object is allocated to respline at :
8030 err = ftp_response (csock,
&respline)<http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/wget-1.13/realbugs/report-KG45QU.html#Path9_2>
;
and it's not freed at
8043 return FTPINVPASV;

*Bug No. 9 ~ No. 16:*
As function fd_read_line(..) returns a heap object and there is not any
free statement in programs, memory leaks may occur.


*Bug No. 17:*
req = request_new
()<http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/wget-1.13/realbugs/report-55xqty.html#Path49_2>
;
req is not freed along the annotated path.

*Bug No. 20:*
There are two kinds of bugs in this report.
The first one:
at function setval_internal_tilde,
8278 home = home_dir
()<http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/wget-1.13/realbugs/report-MuxcQK.html#Path11_3>;

home should be released at the end of this function.

The second one:
before the following assignment
*pstring = concat_strings (home, "/", val, (char *)0);
As pstring = commands[comind].place, Should we free commands[comind].place
at first to avoid the reassignment?
-- 
Zhenbo Xu