Re: [Bug-wget] Wget 1.11.4 and FTP Server from Windows Server 2008 R2

[Ray Satiro]

----- Original Message -----
> From: Giuseppe Scrivano <address@hidden>
> To: Ray Satiro <address@hidden>
> Cc: "address@hidden" <address@hidden>
> Sent: Sunday, October 7, 2012 9:55 AM
> Subject: Re: [Bug-wget] Wget 1.11.4 and FTP Server from Windows Server 2008 R2
> 
> Ray Satiro <address@hidden> writes:
> 
>>  Attached is a patch relative to commit e9845d2. I propose that base
>>  should always be null terminated. tail represents the length of the
>>  string and does not include the terminating null. Any function
>>  directly writing to the members of a growable string object must call
>>  append_null(). Functions that already do this I've changed to call
>>  append_null(): shorten_length(), append_char(), append_string(),
>>  append_uri_pathel().
> 
> could you please send it in a git format-patch format and include the
> changes to the ChangeLog file?


Ok. I will use format-patch and make it relative to 13c6e78.  I think having a 
string object is a good idea but it could use more supporting functions so it 
is not tempting to write to its members directly. There is still more that 
could be done if anyone is interested. For example instead of 
free(somestr.base) it would be better to have something like 
free_strobj(somestr) and then have that function free the memory and zero out 
its members.

I see you've accepted Tim's PATH_MAX substitution in 22bd801. As I mentioned 
earlier in the thread I've found PATH_MAX to be inconsistent and that's why I 
use MAX_PATH. Also I think the changes in 67e6027 need to be thoroughly tested. 
I'm sorry but I don't have more time to look at all this.