Re: [Bug-wget] [PATCH] Invalid Content-Length header in WARC files, on some platforms

[Ángel González]

On 26/11/12 09:06, Tim Ruehsen wrote:
> Am Saturday 24 November 2012 schrieb Ángel González:
>> Stephanie Rühsen schrieb:
>>> Am Samstag, 24. November 2012 schrieb Ángel González:
>>>> The 22 is a magic number, based in the fact
>>>> that 1e21 > INT64_MAX
>>>>
>>>> I think it should be #defined in wget.h
>>>>
>>>> It could be defined variable depending on the
>>>> different MAX values, eg. sizeof( STRINGIZE( INT64_MAX ) )
>>> I found INT64_MAX in stdint.h. AFAIK, it is c99 !?
>>> You don't deserve c99 featurs, do you ? ;-)
>> Don't worry, there's also the pre-c99 <limits.h> :)
> ???
> I just checked my ~10 years old SuSE 7.3 system:
> gcc version is 2.95.3, but it alrerady has <stdint.h> with INT64_MAX defined.
> The define is not in <limits.h> !
>
> AFAIK, many C99 features where derived from gcc extensions.
In C89 you are not even guaranteed to have an int64. But such thing
should not
be a problem when you are placing it inside wget.h where wgint is
detected based
on different defines and autoconf checks.

I mentioned INT64_MAX as a shorthand, not as the value to always use. Maybe I 
wasn't 
clear enough, and maybe I misinterpreted you, too. The solution suggested by 
Giuseppe 
doesn't need a MAX constant, so there shouldn't be issues with that.


Best regards