[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Syntax for RESTful scripting options
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] Syntax for RESTful scripting options |
Date: |
Sat, 16 Mar 2013 21:34:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) |
Hi Darshit,
Darshit Shah <address@hidden> writes:
> I have implemented a --method command along with --body-data and --body-file
> commands for HTTP Scripting.
>
> Have attached the patch alongwith this mail. However, this is not complete,
> not to my satisfaction atleast.
> There is redundant code that executes the old --post-data and --post-file
> commands.
great work! Just some comments:
+ else if (opt.method)
+ {
+ char *q;
+ int s = strlen (opt.method);
+ for ( q = opt.method; s>=0; ++q, s-- )
+ *q = c_toupper (*q);
+ meth = opt.method;
+ }
this could be simplified as:
for (q = opt.method; *q; ++q)
then you don't need s at all.
The new flags should be documented, could you add also the documentation
for those?
Cheers,
Giuseppe
- Re: [Bug-wget] Syntax for RESTful scripting options, (continued)
- Re: [Bug-wget] Syntax for RESTful scripting options, Tim Rühsen, 2013/03/09
- Re: [Bug-wget] Syntax for RESTful scripting options, Giuseppe Scrivano, 2013/03/10
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Giuseppe Scrivano, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Giuseppe Scrivano, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Giuseppe Scrivano, 2013/03/11
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/15
- Re: [Bug-wget] Syntax for RESTful scripting options,
Giuseppe Scrivano <=
- Re: [Bug-wget] Syntax for RESTful scripting options, Darshit Shah, 2013/03/17
- Re: [Bug-wget] Syntax for RESTful scripting options, Hrvoje Niksic, 2013/03/09
- Re: [Bug-wget] Syntax for RESTful scripting options, Tony Lewis, 2013/03/09
- Re: [Bug-wget] Syntax for RESTful scripting options, Hrvoje Niksic, 2013/03/10
Re: [Bug-wget] Syntax for RESTful scripting options, Ángel González, 2013/03/08