[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Submitting a patch fixing the --content-disposition optio
From: |
Vladimír Pýcha |
Subject: |
Re: [Bug-wget] Submitting a patch fixing the --content-disposition option of wget |
Date: |
Tue, 4 Mar 2014 02:56:21 +0100 |
That's great. Thank you very much. It was my first contribution to free or
open source software.
Regards,
Vlad
On Mon, Mar 3, 2014 at 11:16 AM, Giuseppe Scrivano <address@hidden>wrote:
> Vladimír Pýcha <address@hidden> writes:
>
> > Ok, attached is the new patch file with all edits mentioned in ChangeLog.
>
> thanks for your contribution. I've applied this small fixup (just
> aesthetic) on your patch and pushed it:
>
> diff --git a/src/http.c b/src/http.c
> index 690fcde..8306f99 100644
> --- a/src/http.c
> +++ b/src/http.c
> @@ -1040,7 +1040,7 @@ modify_param_name(param_token *name)
> static void
> modify_param_value (param_token *value, int encoding_type )
> {
> - if (RFC2231_ENCODING == encoding_type)
> + if (encoding_type == RFC2231_ENCODING)
> {
> const char *delim = memrchr (value->b, '\'', value->e - value->b);
> if ( delim != NULL )
> @@ -1133,7 +1133,7 @@ extract_param (const char **source, param_token
> *name, param_token *value,
> int param_type = modify_param_name(name);
> if (NOT_RFC2231 != param_type)
> {
> - if (RFC2231_ENCODING == param_type && is_url_encoded)
> + if (param_type == RFC2231_ENCODING && is_url_encoded)
> *is_url_encoded = true;
> modify_param_value(value, param_type);
> }
>
> Regards,
> Giuseppe
>