[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [GSoC] Refactoring the Test Suite
From: |
Zihang Chen |
Subject: |
Re: [Bug-wget] [GSoC] Refactoring the Test Suite |
Date: |
Mon, 10 Mar 2014 15:46:47 +0800 |
Hi Yousong,
So sorry about the line endings, I'll have to do a thorough check.
BTW, the pyc files in 0001.patch was deleted in the second commit.
And thanks very much for the advice!
2014-03-10 15:38 GMT+08:00 Yousong Zhou <address@hidden>:
> Hi, Zihang,
>
> On 10 March 2014 13:05, 陈子杭 (Zihang Chen) <address@hidden> wrote:
> > Hi, Darshit.
> > I fixed the line ending using git config --global autocrlf input. Line
> > endings should be lf now. I also added some documentation. File modes for
> > Test-*.py are 755 now.
> >
>
> I just did a quick check on the patch and the line endings are still
> wrong, e.g. testenv/test/http_test.py
>
> Also, .pyc files should not be included, right?
>
> I do not have much experience with parallel-wget, but you can enhance
> organizing your commits by following how existing ones in the
> repository were written.
>
>
> yousong
>
--
Regards,
Chen Zihang,
Computer School of Wuhan University
---
此致
陈子杭
武汉大学计算机学院
- [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/08
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/08
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/08
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Yousong Zhou, 2014/03/08
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/08
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Yousong Zhou, 2014/03/09
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/09
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Yousong Zhou, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite,
Zihang Chen <=
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/10
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/12
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/12
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/13
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Yousong Zhou, 2014/03/14
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Zihang Chen, 2014/03/14
- Re: [Bug-wget] [GSoC] Refactoring the Test Suite, Darshit Shah, 2014/03/14