[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget
From: |
Jure Grabnar |
Subject: |
Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget |
Date: |
Sat, 22 Mar 2014 11:02:30 +0100 |
Hi,
thank you for your feedback, Darshit, Yousong!
I reverted magic number back to its original state ('tmp2'), because it
should
be there (I overlooked that 'tmp' variable is changed in the very next
statement).
Duplicated line is removed.
I also changed resource->type to point at dynamic memory.
They say third's time's the charm. :) I hope it's ok now.
Regards,
Jure Grabnar
On 21 March 2014 14:31, Yousong Zhou <address@hidden> wrote:
> Hi, Jure.
>
> On 21 March 2014 03:23, Jure Grabnar <address@hidden> wrote:
> > Thank you for you feedback Darshit. I changed my proposal according to
> your
> > advices. Hopefully a new version is better.
> >
> > I'm also sending corrected patches, again thanks to your review, Darshit.
> > First patch allows Metalink to have optional argument "type" in <url>
> > field. Where type is not present, it extracts protocol type from URL
> string.
> >
>
> On the 1st patch, static "char *" value should not be assigned to
> resource->type that will later be free()'ed.
>
>
> yousong
>
0001-Fix-metalink-issues-when-type-is-not-present.patch
Description: Text Data
0002-Fix-some-compiler-warnings.patch
Description: Text Data
- [Bug-wget] [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/17
- [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/17
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/17
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/19
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/20
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/20
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/21
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/21
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget,
Jure Grabnar <=
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/22
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Darshit Shah, 2014/03/27
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/27
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/28
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/28
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/30
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Jure Grabnar, 2014/03/31
- Re: [Bug-wget] Fwd: [GSoC] Extend concurrency support in Wget, Yousong Zhou, 2014/03/31