Re: [Bug-wget] [Bug-Wget][Patch] Implement --show-progress

[Darshit Shah]

On Thu, May 1, 2014 at 11:58 PM, Gisle Vanem <address@hidden> wrote:

> "Darshit Shah" <address@hidden> wrote:
>
>  In a gist, this patch:
>> 1. Cleans up output in case of dot-style progress bar by not printing
>> extra
>> newlines when not needed
>> 2. Ensures all the columns are perfectly aligned in all (?) cases
>>
>
> Not quite; as you said the indenting on >1 lines is a feature. Okay, but
> the
> " --.-K/s" is indented 2 spaces relative to the 1st line and the "in
> 0.004s" is indented 1 space. As in this example:
>
> I'm not sure I see it. I copied the output you provided into a console to
get a monospace view. Attached a screenshot of how it looks. That seems
perfectly aligned to me.

There shouldn't be 'indenting' on lines > 1. That would be a bug. The
offset in the filename is a feature. But that's a sliding window, not an
indentation. Again, if I look at your output in monospace fonts, I don't
see that happening.

Also, I'm not sure which version of the patch you're using. Since the one
above is supposed to have changed the output slightly, so that you see
'--.-KB/s' instead of '--.-K/s'. I did this because I thought the output
looked more uniform that way.


> wget.exe -rApng --show-progress -q ftp://ftp.watt-32.net/watt-doc/
>
> ftp.watt-32.net/watt-doc/.listing     [    <=>                  ] 56,013
>     77.2KB/s   in 0.7s
> tp.watt-32.net/watt-doc/doxygen.p 100%[========================>] 1,576
>     --.-K/s   in 0.004s
> tp.watt-32.net/watt-doc/ftv2blank 100%[========================>] 174
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2doc.p 100%[========================>] 255
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2folde 100%[========================>] 259
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2folde 100%[========================>] 261
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2lastn 100%[========================>] 233
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2link. 100%[========================>] 358
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2mlast 100%[========================>] 160
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2mnode 100%[========================>] 194
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2node. 100%[========================>] 235
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2plast 100%[========================>] 165
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2pnode 100%[========================>] 200
>     --.-K/s   in 0s
> tp.watt-32.net/watt-doc/ftv2vertl 100%[========================>] 229
>     --.-K/s   in 0.001s
>
> This maybe have something to with the ".listing" file since with HTTP all
> looks okay.
>
> It looked fine to me with HTTP downloads. And since both HTTP and FTP use
the exact same code for progress bars, I don't think there should be a
difference. I tried recursively downloading froma FTP server too. Without
any issues. The columns seem to align fine.

I want to believe it is an issue with the .listing file. But I don't see
how. If it is, then the issue *might* be in parsing the file.
I'm unable to access this particular server in your examples which seems to
give problems without access credentials. So, if you could share the
.listing file, maybe I can debug more.


> (use proportional fonts to see the above misalignment).
>
> --gv
>



-- 
Thanking You,
Darshit Shah

monospace_output.jpg
Description: JPEG image