[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [Bug-Wget][PATCH] Add valgrind based testing too test sui
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [Bug-Wget][PATCH] Add valgrind based testing too test suite |
Date: |
Wed, 23 Jul 2014 20:55:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Darshit Shah <address@hidden> writes:
> Hi,
>
> I've attached a patch which enables all the tests in our test suite to
> run through valgrind This behaviour can be invoked by setting the
> environment variable: VALGRIND_TESTS.
>
> Simultaneously, I also propose that we merge the new python based test
> suite into origin/master, to ensure that all new tests are created for
> the new test suite. In case a feature isn't implemented, we can add it
> ASAP.
have you already tried to run it against master? If it just works, we
can do that without postponing it anymore.
>
> --
> Thanking You,
> Darshit Shah
>
> From 6140b1b6e3831a35fd2cf4536fda741a4dcc9019 Mon Sep 17 00:00:00 2001
> From: Darshit Shah <address@hidden>
> Date: Wed, 23 Jul 2014 18:42:43 +0530
> Subject: [PATCH] Support running tests through valgrind
>
> ---
> testenv/ChangeLog | 8 ++++++++
> testenv/README | 6 +++++-
> testenv/conf/expected_ret_code.py | 11 +++++++----
> testenv/test/base_test.py | 6 +++++-
> 4 files changed, 25 insertions(+), 6 deletions(-)
ACK.
Giuseppe