Re: [Bug-wget] [PATCH] Fixing C89 warnings

[Ángel González]

On 20/11/14 16:56, Gisle Vanem wrote:
> FYI. the error from MSVC was:
>   progress.c(844) : error C2010: '*' : unexpected in macro formal 
> parameter list
>   progress.c(978) : error C2059: syntax error : 'do'
>
> Here is a patch:
>
> --- ../Git-latest/src/progress.c        2014-11-20 15:39:55 +0000
> +++ progress.c  2014-11-20 16:44:03 +0000
> @@ -841,10 +841,7 @@
>  }
>  #else
>  # define count_cols(mbs) ((int)(strlen(mbs)))
> -# define cols_to_bytes(mbs, cols, *ncols) do {  \
> -    *ncols = cols;                              \
> -    bytes = cols;                               \
> -}while (0)
> +# define cols_to_bytes(mbs, cols, ncols) *ncols = cols
>  #endif
I suggested this same change last month (2014-10-11). ACK