[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Patch: Ports test for restrict-filename to python
From: |
Darshit Shah |
Subject: |
Re: [Bug-wget] Patch: Ports test for restrict-filename to python |
Date: |
Sun, 29 Mar 2015 13:54:30 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi Elita,
Comments inline..
From 712ede22ec4eaf397dba32dc297ba9fd54356ee1 Mon Sep 17 00:00:00 2001
From: Elita Lobo <address@hidden>
Date: Sat, 28 Mar 2015 23:07:44 +0530
Subject: [PATCH] Test-E-k.py: Tests -E -k feature of Wget
The commit message needs to state the base module too.
testenv/Test-E-k.py: Add new test
---
testenv/Test-E-k.py | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 87 insertions(+)
create mode 100755 testenv/Test-E-k.py
I see that the test hasn't been added to Makefile.am. Please add your tests to
the Makefile so that they are executed upon "make check"
+File_Rules = {
+ "SendHeader" : {
+ "Content-Type" : "text/html"
Indentation...
Subject: [PATCH] Test-restrict-ascii.py: Tests restrict-filename=ascii feature
Test-restrict-lowercase.py: Tests restrict-filename=lowercase feature
Test-restrict-uppercase.py: Tests restrict-filename=uppercase feature
Take a look at the following link for writing better commit messages:
http://chris.beams.io/posts/git-commit/
+"""
+ This program tests that --restrict-file-names=ascii can be used to
This "test" tests the following feature.. Just being pedantic.
From 04e07c23d220ad0952f21e4655c4ccb7620aba48 Mon Sep 17 00:00:00 2001
From: Elita Lobo <address@hidden>
Date: Sat, 28 Mar 2015 23:04:15 +0530
Subject: [PATCH] Test-start-pos--continue.py: Tests --start-pos --continue
I'm pretty sure we can come up with a better name for the test. It doesn't
always have to be the list of switches sent to Wget
Also, I think testing start-pos should be a test in itself. This test can
compliment it to ensure that the invalid switches don't work together.
From 16125a14b57b5615cd31eeadc700c21bcae00e89 Mon Sep 17 00:00:00 2001
From: Elita Lobo <address@hidden>
Date: Sat, 28 Mar 2015 19:22:26 +0530
Subject: [PATCH] testenv/Test-lack-of-a-range-header-support.py: Tests Wget's
response against erroneous server response.
Again, I'm pretty sure, we can come up with a better name.
+"""
+ Tests if Wget correctly downloads a file which previously failed to
download
+ completely.
+"""
Not true. Your test checks if Wget correctly handles a 200 response to a valid
Range Header.
+File2_rules = {
+ "Response" : 200,
+ "SendHeader" : {
+ "Content-Length" : len(File2)
Indentation....
--
Thanking You,
Darshit Shah
pgptUkeAjqTzC.pgp
Description: PGP signature