[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded
From: |
Ander Juaristi |
Subject: |
Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded |
Date: |
Tue, 08 Sep 2015 17:41:40 +0200 |
I remember this same issue being raised not so much ago, which ended up in a
wontfix. However, now that we have something to set up and run, something clear
to test, maybe the results are acceptable :D
Sent from my smartphone. Excuse my brevity.
---- Christian Neukirchen escribió ----
>Hi,
>
>Sometimes I start wget, but the remote site is too slow, so I rather
>want to run it in background, however when I simply use job control
>for that, wget will keep spewing the progress bar all over my
>terminal. I have found the SIGHUP/SIGUSR1 feature to redirect output
>to a log file, but I think the following small patch is even more
>useful, since the progress bar will simply resume when wget is
>foregrounded again (also, the final message is still printed to the
>terminal in any case):
>
>--- src/progress.c
>+++ src/progress.c
>@@ -1179,10 +1179,12 @@ create_image (struct bar_progress *bp, double
>dl_total_time, bool done)
> static void
> display_image (char *buf)
> {
>- bool old = log_set_save_context (false);
>- logputs (LOG_PROGRESS, "\r");
>- logputs (LOG_PROGRESS, buf);
>- log_set_save_context (old);
>+ if (tcgetpgrp (fileno (stderr)) == getpid ()) {
>+ bool old = log_set_save_context (false);
>+ logputs (LOG_PROGRESS, "\r");
>+ logputs (LOG_PROGRESS, buf);
>+ log_set_save_context (old);
>+ }
> }
>
> static void
>
>This probably needs some guards for portability to all platforms.
>Only tested on Linux 4.1 so far.
>
>Opinions?
>
>--
>Christian Neukirchen <address@hidden> http://chneukirchen.org
>
- [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Christian Neukirchen, 2015/09/08
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded,
Ander Juaristi <=
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Tim Ruehsen, 2015/09/09
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Tim Ruehsen, 2015/09/10
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Darshit Shah, 2015/09/21
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Christian Neukirchen, 2015/09/21
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Tim Ruehsen, 2015/09/22
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Gisle Vanem, 2015/09/22
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Tim Ruehsen, 2015/09/22
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Jernej Simončič, 2015/09/22
- Re: [Bug-wget] Feature: Disabling progress bar when wget is backgrounded, Ángel González, 2015/09/22