Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

[Tim Ruehsen]

Hi Dagobert,

On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote:
> Hi,
> 
> Am 16.11.2015 um 14:53 schrieb Jernej Simončič <address@hidden>:
> > Looks like hsts.c tries to use flock with a parameter that doesn't
> > work on Windows:
> > 
> > x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H
> > -DSYSTEM_WGETRC=\"/win32dev/misc/wget/out64/etc/wgetrc\"
> > -DLOCALEDIR=\"/win32dev/misc/wget/out64/share/locale\" -I.  -I../lib
> > -I../lib -I/win32dev/misc/wget/out64/include 
> > -I/win32dev/misc/wget/out64/include  -DHAVE_LIBSSL  -DNDEBUG  -MT hsts.o
> > -MD -MP -MF .deps/hsts.Tpo -c -o hsts.o hsts.c hsts.c: In function
> > 'hsts_store_dump':
> > hsts.c:329:20: warning: format '%lu' expects argument of type 'long
> > unsigned int', but argument 6 has type 'time_t' [-Wformat=]> 
> >                    khi->created, khi->max_age) < 0)
> >                    ^
> > 
> > hsts.c:329:20: warning: format '%lu' expects argument of type 'long
> > unsigned int', but argument 7 has type 'time_t' [-Wformat=] hsts.c: In
> > function 'hsts_store_save':
> > hsts.c:505:22: error: 'LOCK_EX' undeclared (first use in this function)
> > 
> >           flock (fd, LOCK_EX);
> >           
> >                      ^
> > 
> > hsts.c:505:22: note: each undeclared identifier is reported only once for
> > each function it appears in
> Same here on Solaris 10 with Oracle Studio 12:
> > /opt/csw/bin/gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\"
> > -DLOCALEDIR=\"/usr/local/share/locale\" -I.  -I../lib -I../lib
> > -D_REENTRANT  -I/opt/csw/include   -I/opt/csw/include -I/opt/csw/include 
> >  -I/opt/csw/include -I/opt/csw/include/p11-kit-1   -DHAVE_LIBGNUTLS
> > -I/opt/csw/include   -I/opt/csw/include   -DNDEBUG  -MT hsts.o -MD -MP
> > -MF .deps/hsts.Tpo -c -o hsts.o hsts.c
> > 
> > hsts.c: In function 'hsts_store_save':
> > hsts.c:505:22: error: 'LOCK_EX' undeclared (first use in this function)
> > 
> >            flock (fd, LOCK_EX);
> >            
> >                       ^
> > 
> > hsts.c:505:22: note: each undeclared identifier is reported only once for
> > each function it appears in
> > 
> > Makefile:1573: recipe for target 'hsts.o' failed
> 
> Also the builds are failing for quite some time:
>   https://buildfarm.opencsw.org/buildbot/waterfall?category=wget
> 
> Unfortunately I didn’t get any feedback at all when I mentioned compiling
> issues: http://lists.gnu.org/archive/html/bug-wget/2015-07/msg00068.html

This is still open here as an issue (but with low priority).
We are definitely not enough developers here...

These failures might be simple things like a missing include directive.
It would would be very helpful if you could just tell us "hey, adding this 
line ... fixes it". Thats 10 minutes for you and 10 for us, and voila.

But if compilation fails within your build farm, couldn't you send a mail to 
address@hidden ? I know you already suggested something like this...

Regards, Tim